[CAMEL-17599] camel-jdbc - JdbcProducer leaks PreparedStatement

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.14.1, 3.15.0
• Fix Version/s: 3.14.2, 3.16.0
• Component/s: camel-jdbc
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: James Netherton
• Created: 04/Feb/22 10:41
• Updated: 10/Apr/23 09:33
• Resolved: 05/Feb/22 11:38

Description

Originally reported on the a Quarkus Zulip thread:

https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Camel.20JDBC.20leaks.20statement

There are 2 different execution paths in JdbcProducer. doCreateAndExecuteSqlStatementWithHeaders & doCreateAndExecuteSqlStatement.

doCreateAndExecuteSqlStatementWithHeaders does close the PreparedStatement:

https://github.com/apache/camel/blob/camel-3.14.1/components/camel-jdbc/src/main/java/org/apache/camel/component/jdbc/JdbcProducer.java#L185-L188

doCreateAndExecuteSqlStatement does not:

https://github.com/apache/camel/blob/camel-3.14.1/components/camel-jdbc/src/main/java/org/apache/camel/component/jdbc/JdbcProducer.java#L244-L246

This PR & commit suggests auto-closing is perhaps not desirable:

https://github.com/apache/camel/pull/6192

The code prior to Camel 3.12.x did close the PreparedStatement in the finally block, so maybe that should be restored.

Issue Links

• is related to: CAMEL-19256 camel-jdbc: leaks the statement in doCreateAndExecuteSqlStatement
• is related to: CAMEL-17032 camel-jdbc: investigate if resource usage can be improved