[CAMEL-17202] camel-rest-openapi - If two openapi spec uses the same path only one rest endpoint is created

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.13.0
• Fix Version/s: 3.14.0
• Component/s: camel-rest-openapi
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Henrik Karlsson
• Created: 17/Nov/21 10:23
• Updated: 23/Nov/21 05:41
• Resolved: 22/Nov/21 13:46

Description

If two openapi spec uses the same method, basePath and uriTemplate the componentEndpointUri will be the same. Then the second endpoint is created the first one  is found in the camel context and the host property is overwritten. This causes all calls to these operations in routes goes to the second api.

API One:
host: https://api.one.com
method: GET
basePath: /api
uriTemplate: /users/{email}
title: api-one
version: 1.0.2

API Two:
host: https://api.two.com
method: GET
basePath: /api
uriTemplate: /users/{email}
title: api-two
version: 2.0.1

In RestOpenApiEndpoint.createProducerFor() the componentEndpointUri is created like this:

final String componentEndpointUri = "rest:" + method + ":" + basePath + ":" + uriTemplate 

For both of the operations described above the componentEndpointUri will be

"rest:GET:/api:/users/{email}"

When the camelContext.getEndpoint is called with this uri for API Two the endpoint for created for API One is returned instead of creating a new and the host parameter is set to 'https://api.two.com'.

To solve this I've added title and version from the openapi spec as query parameters to the componentEndpointUri:

final String componentEndpointUri = "rest:" + method + ":" + basePath + ":" + uriTemplate
    + "?title=" + openapi.info.title + "&version=" + openapi.info.version; 

Title and version are required in OpenAPI 3.x so they should always be available.

Issue Links

• links to: GitHub Pull Request #6444