[CAMEL-17105] Transactions - Ignored property Exchange.markRollbackOnlyLast

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.11.3, 3.12.0
• Fix Version/s: 3.13.0, 3.11.4
• Component/s: camel-spring
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Nick Smith
• Created: 18/Oct/21 20:58
• Updated: 19/Oct/21 09:08
• Resolved: 19/Oct/21 09:08

Description

In Camel 3.x Exchange was refactored and markRollbackOnly was changed 
from 2.x

    public boolean isRollbackOnly() {
        return Boolean.TRUE.equals(getProperty(Exchange.ROLLBACK_ONLY)) || Boolean.TRUE.equals(getProperty(Exchange.ROLLBACK_ONLY_LAST));
    }

to 3.x

    public boolean isRollbackOnly() {
        return rollbackOnly;
    }

Now in TransactionErrorHandler.doInTransactionTemplate() doesn't throw TransactionRollbackException, cause isRollbackOnly false.

            protected void doInTransactionWithoutResult(TransactionStatus status) {
                // wrapper exception to throw if the exchange failed
                // IMPORTANT: Must be a runtime exception to let Spring regard it as to do "rollback"
                RuntimeException rce;

                // and now let process the exchange by the error handler
                processByErrorHandler(exchange);

                // after handling and still an exception or marked as rollback only then rollback
                if (exchange.getException() != null || exchange.isRollbackOnly()) {

                    // wrap exception in transacted exception
                    if (exchange.getException() != null) {
                        rce = RuntimeCamelException.wrapRuntimeCamelException(exchange.getException());
                    } else {
                        // create dummy exception to force spring transaction manager to rollback
                        rce = new TransactionRollbackException();
                    }

                    if (!status.isRollbackOnly()) {
                        status.setRollbackOnly();
                    }

                    // throw runtime exception to force rollback (which works best to rollback with Spring transaction manager)
                    if (LOG.isTraceEnabled()) {
                        LOG.trace("Throwing runtime exception to force transaction to rollback on {}",
                                transactionTemplate.getName());
                    }
                    throw rce;
                }
            }

Issue Links

• links to: GitHub Pull Request #6300