[CAMEL-16395] Unpredictable behaviour of camel main routes health check configuration

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.10.0
• Component/s: camel-main
• Estimated Complexity: Unknown
• Assignee: James Netherton
• Reporter: James Netherton
• Created: 24/Mar/21 09:51
• Updated: 25/Mar/21 14:47
• Resolved: 25/Mar/21 14:47

Description

I noticed there's some non-deterministic behaviour going on with the Camel health check config in camel-main. Consider the following configuration to disable the 'netty' route from the RouteHealthCheck:

camel.health.config[netty].enabled = true
camel.health.config[timer].enabled = false

In BaseMainSupport there is this logic:

https://github.com/apache/camel/blob/master/core/camel-main/src/main/java/org/apache/camel/main/BaseMainSupport.java#L989

Depending on the order in which the config properties are processed, RoutesHealthCheckRepository will either be enabled or disabled.

I think the code on line 989 in BaseMainSupport support is not required. I think it's enough to just add the configuration like here:

https://github.com/apache/camel/blob/master/core/camel-main/src/main/java/org/apache/camel/main/BaseMainSupport.java#L990

Issue Links

• relates to: CAMEL-16396 Configuring an interval and failure threshold for a health check does not work in all cases
• links to: GitHub Pull Request #5266