Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-16395

Unpredictable behaviour of camel main routes health check configuration

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.10.0
    • Component/s: camel-main
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Description

      I noticed there's some non-deterministic behaviour going on with the Camel health check config in camel-main. Consider the following configuration to disable the 'netty' route from the RouteHealthCheck:

      camel.health.config[netty].enabled = true
      camel.health.config[timer].enabled = false

      In BaseMainSupport there is this logic:

      https://github.com/apache/camel/blob/master/core/camel-main/src/main/java/org/apache/camel/main/BaseMainSupport.java#L989

      Depending on the order in which the config properties are processed, RoutesHealthCheckRepository will either be enabled or disabled.

      I think the code on line 989 in BaseMainSupport support is not required. I think it's enough to just add the configuration like here:

      https://github.com/apache/camel/blob/master/core/camel-main/src/main/java/org/apache/camel/main/BaseMainSupport.java#L990

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jamesnetherton James Netherton
                Reporter:
                jamesnetherton James Netherton
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: