[CAMEL-15893] onJobExecute method of org.apache.camel.routepolicy.quartz2.ScheduledRoutePolicy should be public

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.7.0, 2.25.3
• Component/s: camel-quartz2, osgi
• Estimated Complexity: Unknown
• Assignee: Freeman Yue Fang
• Reporter: Freeman Yue Fang
• Created: 25/Nov/20 19:06
• Updated: 26/Nov/20 14:54
• Resolved: 26/Nov/20 14:54

Description

Other wise can't access this method from a proxy.
For example, if we expose the service in blueprint from one bundle like

<bean id="myPolicy" class="org.apache.camel.routepolicy.quartz2.CronScheduledRoutePolicy">
                <property name="routeStartTime" value="....."/>
                <property name="routeStopTime" value="...."/>
        </bean>

        

        <service ref="myPolicy" auto-export="all-classes"/>

And refer it in another bundle like this

                 <reference id="remote-policy"
                                interface="org.apache.camel.routepolicy.quartz2.ScheduledRoutePolicy"
                                ext:proxy-method='classes'" />
                 <route id="route-remote" routePolicyRef="remote-policy" autoStartup="false">
                        ....
                </route>

Since here the remote-policy reference from aries blueprint is actually a proxy, so we will run into error like

at org.apache.camel.routepolicy.quartz2.ScheduledJob.execute(ScheduledJob.java:62) ~[!/:2.21.0.fuse-770013-redhat-00001]
	at org.quartz.core.JobRunShell.run(JobRunShell.java:202) [!/:2.3.2.redhat-00007]
	at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) [!/:2.3.2.redhat-00007]
Caused by: java.lang.IllegalAccessException: Class org.apache.aries.proxy.impl.ProxyHandler$1 can not access a member of class org.apache.camel.routepolicy.quartz2.ScheduledRoutePolicy with modifiers "protected"
	at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102) ~[?:1.8.0_221]
	at java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296) ~[?:1.8.0_221]
	at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288) ~[?:1.8.0_221]
	at java.lang.reflect.Method.invoke(Method.java:491) ~[?:1.8.0_221]
	at org.apache.aries.proxy.impl.ProxyHandler$1.invoke(ProxyHandler.java:54) ~[?:?]
	at org.apache.aries.proxy.impl.ProxyHandler.invoke(ProxyHandler.java:119) ~[?:?]
	at org.apache.camel.routepolicy.quartz2.$ScheduledRoutePolicy566505575.onJobExecute(Unknown Source) ~[!/:2.21.0.fuse-770013-redhat-00001]
	at org.apache.camel.routepolicy.quartz2.ScheduledJob.execute(ScheduledJob.java:53) ~[!/:2.21.0.fuse-770013-redhat-00001]

So to make this method available for the proxy, we should change its modifier as "public"

If there's no objection, I will make this change