[CAMEL-1583] ldap component is not thread safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0, 2.0-M1
• Fix Version/s: 1.6.1, 2.0-M2
• Component/s: camel-ldap

Environment

N/A

• Assignee: Claus Ibsen
• Reporter: Christopher Hunt
• Created: 02/May/09 10:20
• Updated: 21/Nov/09 11:58
• Resolved: 04/May/09 14:05

Description

JNDI context objects are not thread-safe. The LDAP component shares a directory context across all threads that use the component. This is not safe.

In addition the LDAP component will attempt to establish a connection on instantiation of the component, and not when the component is required to process requests. If the LDAP server is not ready e.g. temporarily unavailable then the entire Camel application will stop.

JNDI directory contexts should be established when a consuming thread needs it and should be released when the thread is finished with the component i.e.:

ctx = new InitialDirContext(env);
try {
  ...
} finally {
  ctx.close();
}

The above will release the connection with the LDAP server as soon as possible. The existing component relies on JNDI to release the socket in its own time (several seconds later).