[CAMEL-15262] ZooKeeperCuratorHelper: wrong argument order when creating a new ExponentialBackoffRetry

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.1, 3.5.0
• Component/s: camel-zookeeper
• Estimated Complexity: Unknown
• Assignee: Andrea Cosentino
• Reporter: Ahmed M
• Created: 30/Jun/20 20:49
• Updated: 03/Jul/20 13:46
• Resolved: 03/Jul/20 13:46

Description

The constructor args maxRetries (reconnectMaxRetries) and maxSleepMs (reconnectMaxSleepTime) are reversed when creating a new ExponentialBackoffRetry in ZooKeeperCuratorHelper.createCurator :

if (retryPolicy == null) {
    retryPolicy = new ExponentialBackoffRetry(
        (int)configuration.getReconnectBaseSleepTimeUnit().toMillis(configuration.getReconnectBaseSleepTime()),
        (int)configuration.getReconnectMaxSleepTimeUnit().toMillis(configuration.getReconnectMaxSleepTime()),
        configuration.getReconnectMaxRetries());
}

CuratorFramework API javadoc:

ExponentialBackoffRetry(int baseSleepTimeMs, int maxRetries, int maxSleepMs) 

Issue Links

• links to: Github PR #3963
• links to: GitHub Pull Request #3963
• links to: GitHub Pull Request #3964