Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6.0
    • Fix Version/s: 1.6.1, 2.0-M2
    • Component/s: documentation
    • Labels:
      None

      Description

      the example URI for the camel-irc component (see http://camel.apache.org/irc.html) does not work. Further, the current URI parsing code is flawed and subject to NPE's.

      In IrcConfiguration.configure(URI uri) (see https://svn.apache.org/repos/asf/camel/branches/camel-1.x/components/camel-irc/src/main/java/org/apache/camel/component/irc/IrcConfiguration.java) the code attempts to parse a channel name as a path. Because the '#' char is a fragment marker in a URI, the path (in the documented example) is zero length.

      The following URI works with the current code implementation (note the required '//' and html-escaped '#' char):

      irc://nick@server.org/%23channel
      1. patch.txt
        2 kB
        Stan Lewis

        Activity

        Hide
        Claus Ibsen added a comment -

        Closing all 2.0M2 tickets

        Show
        Claus Ibsen added a comment - Closing all 2.0M2 tickets
        Hide
        Darren Davison added a comment -

        it was actually Stan's patch But thanks for applying it.

        Show
        Darren Davison added a comment - it was actually Stan's patch But thanks for applying it.
        Hide
        Claus Ibsen added a comment -

        Thanks Darren for the patch. I have applied it to 1.x and trunk.

        trunk: 766289
        1.x: 766290

        Show
        Claus Ibsen added a comment - Thanks Darren for the patch. I have applied it to 1.x and trunk. trunk: 766289 1.x: 766290
        Hide
        Stan Lewis added a comment -

        Here's a patch that sorts out the NPEs and also makes the runtime follow the documentation. Both irc: and irc:// can be used and you can use '#' instead of %23. Updated the unit test too.

        Show
        Stan Lewis added a comment - Here's a patch that sorts out the NPEs and also makes the runtime follow the documentation. Both irc: and irc:// can be used and you can use '#' instead of %23. Updated the unit test too.

          People

          • Assignee:
            Hadrian Zbarcea
            Reporter:
            Darren Davison
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development