[CAMEL-14243] Opentracing with JMS not working when JmsComponent is defined as a Spring bean

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.24.2
• Fix Version/s: 3.1.0
• Component/s: camel-opentracing
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Serkan
• Created: 03/Dec/19 07:47
• Updated: 05/Dec/19 11:39
• Resolved: 05/Dec/19 11:39

Description

see also:

https://github.com/opentracing/opentracing-java/issues/307#issuecomment-560329283

 

I'm using the following libraries:

-JDK 8

-camel 2.24.2

-camel-jms-2.24.2

-camel-opentracing 2.24.2

-jaeger-client-0.34.0

 

Issue:

-Define JmsComponent as a Spring bean:

@Bean(name = "core-jms")
public JmsComponent createJmsComponentBean(
@Qualifier(value = "core-jmsConnectionFactory") ConnectionFactory connectionFactory) throws JMSException

{ JmsComponent jmsComponent = new JmsComponent(); JmsConfiguration jmsConfiguration = new JmsConfiguration(connectionFactory); jmsConfiguration.setJmsMessageType(JmsMessageType.Text); jmsConfiguration.setUseMessageIDAsCorrelationID(true); jmsComponent.setConfiguration(jmsConfiguration); return jmsComponent; }

If you use this JmsComponent in your route (like: from("core-jms://...) then the protocol name change from jms:// into core-jms:// and the current registered SpanDecorators wont match with this one. What will result into wrong tracing id's among the whole flow.

Thus let's say we have the following situation:

Route A -> Jms Queue -> Route B -> WS call.

What I expect is that Route A and Route B have the same traceId, but what I get is 2 traces:

one for Route A -> Jms Queue, and another one from Jms Queue -> Route B.

 

See also the discussion in the link above for more info.

 

 

Issue Links

• depends upon: CAMEL-14244 camel-opentracing - Associate decorators with component FQN also