[CAMEL-14148] exception during first resolve of temporary jms destination causes infinitive wait

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.24.2
• Fix Version/s: 2.24.3, 3.0.0, 2.25.0
• Component/s: camel-jms
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Bas Claessen
• Created: 06/Nov/19 13:35
• Updated: 24/Oct/22 13:57
• Resolved: 07/Nov/19 17:42

Description

An exception during the first attempt to resolve a temporary destination will cause an infinitive wait for next resolve attempts after the exception is cleared.
A likely scenario for this behaviour to occur is when no connection to a jms server can be established during startup.

This bug is caused by not setting the refreshWanted to false when no previous destination exists in the org.apache.camel.component.jms.reply.TemporaryQueueReplyManager$TemporaryReplyQueueDestinationResolver class.

public Destination resolveDestinationName(Session session, String destinationName, boolean pubSubDomain) throws JMSException {
    // use a temporary queue to gather the reply message
    synchronized (refreshWanted) {
        if (queue == null || refreshWanted.compareAndSet(true, false)) {
            queue = session.createTemporaryQueue();
            setReplyTo(queue);
            if (log.isDebugEnabled()) {
                log.debug("Refreshed Temporary ReplyTo Queue. New queue: {}", queue.getQueueName());
            }
            refreshWanted.notifyAll();
        }
    }
    return queue;
}

When queue == null the refreshWanted.compareAndSet(true, false) is not executed.

Issue Links

• links to: GitHub Pull Request #3324
• links to: GitHub Pull Request #3326
• links to: GitHub Pull Request #3327
• links to: GitHub Pull Request #8618