[CAMEL-13941] NullPointerException when Conduit is null

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.20.1, 2.21.2, 2.23.1, 2.24.1
• Fix Version/s: 2.23.4, 2.24.2, 2.25.0
• Component/s: camel-cxf
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Julien Greffe
• Created: 04/Sep/19 13:24
• Updated: 04/Sep/19 17:35
• Resolved: 04/Sep/19 17:35

Description

Hello,

the CxfProducer.doStart() retrieves a Conduit.

If this Conduit is null, should we still throw a NullPointerException or, should we check nullity before condition?

Conduit conduit = client.getConduit();

        if (conduit.getClass().getName().endsWith("JMSConduit")) {
...
}

https://github.com/apache/camel/blob/camel-2.21.2/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/CxfProducer.java#L87
https://github.com/apache/camel/blob/camel-2.23.1/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/CxfProducer.java#L87
https://github.com/apache/camel/blob/camel-2.24.1/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/CxfProducer.java#L87

Thanks for your point of view.

Issue Links

• links to: GitHub Pull Request #3142