[CAMEL-13860] camel-properties: get[Inital|Override]Properties should never return null

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0.RC1, 3.0.0
• Component/s: camel-properties
• Estimated Complexity: Unknown
• Assignee: Luca Burgazzoli
• Reporter: Luca Burgazzoli
• Created: 12/Aug/19 08:18
• Updated: 12/Aug/19 11:38
• Resolved: 12/Aug/19 11:38

Description

The properties component allow to set initial and override properties but as the methods to access such properties can return null, used may end up writing things like:

@Override
    public void addProperties(Properties properties) {
        PropertiesComponent pc = context.getComponent("properties", PropertiesComponent.class);
        Properties props = pc.getInitialProperties();

        if (props == null) {
            props = new Properties();

            pc.setInitialProperties(props);
        } else {
            props.putAll(properties);
        }
    }

    @Override
    public void addProperty(String key, Object value) {
        PropertiesComponent pc = context.getComponent("properties", PropertiesComponent.class);
        Properties props = pc.getInitialProperties();

        if (props == null) {
            props = new Properties();
            props.put(key, value);

            pc.setInitialProperties(props);
        } else {
            props.put(key, value);
        }
    }

We can implement such lazy initialization logic in the component property itself.