[CAMEL-1384] ExchangeHelper should respect ExchangePattern.InOptionalOut

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 2.0-M1
• Component/s: camel-core

Environment

ActiveMQ/Camel

• Assignee: Claus Ibsen
• Reporter: Michael Chen
• Created: 25/Feb/09 17:54
• Updated: 31/Jul/09 06:34
• Resolved: 27/Feb/09 10:00

Description

The utility method org.apache.camel.util.ExchangeHelper.copyResults() is use by many core classes. However, this method does not properly support MEP InOptionalOut.

Assuming in an InOptionalOut exchange, having no out message means just that – no out message should be sent, then the following lines in this method

//
            Message out = source.getOut(false);
            if (out != null) {
                result.getOut(true).copyFrom(out);
            } else {
                // no results so lets copy the last input

should be changed to:

//
            Message out = source.getOut(false);
            if (out != null) {
                result.getOut(true).copyFrom(out);
            } else if (result.getPattern() == ExchangePattern.InOptionalOut) {
                result.setOut(null);
            } else {
                // no results so lets copy the last input

Issue Links

• is depended upon by: CAMEL-1366 EndpointMessageListener should respect ExchangePattern