[CAMEL-13752] Make a BridgePropertyPlaceholderConfigurer equivalent for PropertySourcePlaceholderConfigurer

• Type: New Feature
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 2.24.1, 3.0.0.M4
• Component/s: camel-spring
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Stig Rohde Døssing
• Created: 16/Jul/19 17:51
• Updated: 02/Sep/22 11:32
• Resolved: 02/Sep/22 11:32

Description

BridgePropertyPlaceholderConfigurer extends Spring's PropertyPlaceholderConfigurer. Spring recommends against using this class for new code, and has a replacement in the PropertySourcesPlaceholderConfigurer. The new class is a prerequisite for e.g. the @TestPropertySource annotation to work. Example usage here https://github.com/apache/camel/blob/camel-2.23.1/components/camel-test-spring/src/test/java/org/apache/camel/test/spring/CamelSpringRunnerTestPropertySourceTest.java

It's not obvious to me whether it would be safe to reimplement BridgePropertyPlaceholderConfigurer to extend PropertySourcesPlaceholderConfigurer instead. I'd guess it wouldn't be backwards compatible, otherwise Spring would probably have just reimplemented PropertyPlaceholderConfigurer.

I think we should add a new BridgePropertySourcesPlaceholderConfigurer that extends PropertySourcesPlaceholderConfigurer. This will allow users to use the Camel property bridging functionality, without losing the ability to override Spring properties in tests.

I am happy to work on this if the idea makes sense.

Issue Links

• links to: GitHub Pull Request #3283