[CAMEL-13397] RedisStringIdempotentRepository resetting expiry on existing keys

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.23.1
• Fix Version/s: 2.24.0, 3.0.0-M3, 2.23.3, 3.0.0
• Component/s: camel-spring-redis
• Estimated Complexity: Unknown
• Assignee: Andrea Cosentino
• Reporter: Chris Schwarzfischer
• Created: 08/Apr/19 11:10
• Updated: 10/Apr/19 13:08
• Resolved: 10/Apr/19 13:08

Description

When getting new input and seeing for example the same file name for the second time before expiry hits, add will simply reset the expiry to the original value independent of the set being successful or not.

This way, the key will never expire if add is called more freuqently than the key expires.

 

public boolean add(String key) {
    boolean added = valueOperations.setIfAbsent(createRedisKey(key), key);
    if (expiry > 0) {
        valueOperations.getOperations().expire(createRedisKey(key), expiry, TimeUnit.SECONDS);
    }
    return added;
}

this should probably rather be:

public boolean add(String key) {
    return valueOperations.setIfAbsent(createRedisKey(key), key, Duration.ofSeconds(expiry));
}