[CAMEL-13373] camel-stax - FileInputStream not closed

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.23.1
• Fix Version/s: 3.0.0.M4, 3.0.0
• Component/s: camel-stax
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Alexandru
• Created: 27/Mar/19 16:17
• Updated: 18/Jun/19 08:14
• Resolved: 18/Jun/19 08:14

Description

The StAXProcessor.java class does not close the stream it opens.

I had to modify it like this: 

public void process(Exchange exchange) throws Exception {
InputSource is = exchange.getIn().getMandatoryBody(InputSource.class);
XMLStreamReader stream = exchange.getIn().getMandatoryBody(XMLStreamReader.class);
// Fermeture de la inputstream ici, car dans la version originale de la classe la stream reste ouverte.
try(InputStream inputStreamToClose = is.getByteStream()) {
XMLReader reader = new StaxStreamXMLReader(stream);
ContentHandler handler;
if (this.contentHandlerClass != null)

{ handler = (ContentHandler) this.contentHandlerClass.newInstance(); }

else

{ handler = this.contentHandler; }

reader.setContentHandler(handler);
reader.parse(is);
if (ExchangeHelper.isOutCapable(exchange))

{ exchange.getOut().setHeaders(exchange.getIn().getHeaders()); exchange.getOut().setBody(handler); }

else

{ exchange.getIn().setBody(handler); }

} finally

*

{ // Fermeture de la strem ValidatingStreamReader validatingStreamReader = (ValidatingStreamReader)stream; validatingStreamReader.closeCompletely(); }

*

}