[CAMEL-13320] DirectMessageConsumerHandler.java [4] pollConsume method calls Twitter.getDirectMessages(getLastIdPaging())

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.23.2, 2.24.0, 2.22.4, 3.0.0-M2, 3.0.0
• Component/s: camel-twitter
• Estimated Complexity: Unknown
• Assignee: Andrea Cosentino
• Reporter: Claudio Miranda
• Created: 12/Mar/19 18:55
• Updated: 13/Mar/19 07:19
• Resolved: 13/Mar/19 07:19

Description

DirectMessageConsumerHandler.java [1] pollConsume method calls Twitter.getDirectMessages(getLastIdPaging()), the method is deprecated [2] and filters out the messages sent by the account [3]. The master version removed the getDirectMessages(Paging p) method and doesn't filter the messages. The fix is to call getDirectMessages(int count) instead.

1. https://github.com/apache/camel/blob/master/components/camel-twitter/src/main/java/org/apache/camel/component/twitter/directmessage/DirectMessageConsumerHandler.java#L39
2. https://github.com/Twitter4J/Twitter4J/blob/4.0.7/twitter4j-core/src/main/java/twitter4j/api/DirectMessagesResources.java#L53
3. https://github.com/Twitter4J/Twitter4J/blob/4.0.7/twitter4j-core/src/main/java/twitter4j/TwitterImpl.java#L422

Issue Links

• links to: GitHub Pull Request #2820