Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-12842

"-" dash is not a valid characters for keys in JMS headers

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.23.0
    • Component/s: camel-opentracing
    • Labels:
      None
    • Estimated Complexity:
      Moderate

      Description

      Hi

      "-", dash is not a valid character for keys in JMS headers. This gets encoded in OpenTracing java-jms client: DASH = "$dash$"; see:

      https://github.com/opentracing-contrib/java-jms/blob/master/opentracing-jms-common/src/main/java/io/opentracing/contrib/jms/common/JmsTextMapInjectAdapter.java

      I am proposing to have the same approach in camel-opentracing. By doing so spans created by Camel can be seen under a trace created by java-jms. I have amended the code accordingly and will raise a pull request. I have extended the change to the abstract messaging class so that it also works when a peer is using JMS for amqp endpoint for instance. A configuration parameter allows to activate/deactivate encoding. If no parameter is provided the behavior is as before for backward compatibility.

      Regards,

      Frédéric

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                aldettinger Alex Dettinger
                Reporter:
                fgiloux Frederic Giloux
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: