[CAMEL-12842] "-" dash is not a valid characters for keys in JMS headers

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.23.0
• Component/s: camel-opentracing
• Estimated Complexity: Moderate
• Assignee: Alex Dettinger
• Reporter: Frederic Giloux
• Created: 28/Sep/18 22:02
• Updated: 29/Sep/18 08:44
• Resolved: 29/Sep/18 08:41

Description

Hi

"-", dash is not a valid character for keys in JMS headers. This gets encoded in OpenTracing java-jms client: DASH = "$dash$"; see:

https://github.com/opentracing-contrib/java-jms/blob/master/opentracing-jms-common/src/main/java/io/opentracing/contrib/jms/common/JmsTextMapInjectAdapter.java

I am proposing to have the same approach in camel-opentracing. By doing so spans created by Camel can be seen under a trace created by java-jms. I have amended the code accordingly and will raise a pull request. I have extended the change to the abstract messaging class so that it also works when a peer is using JMS for amqp endpoint for instance. A configuration parameter allows to activate/deactivate encoding. If no parameter is provided the behavior is as before for backward compatibility.

Regards,

Frédéric

Issue Links

• links to: GitHub Pull Request #2540