[CAMEL-12730] FindBugs warnings: Suspicious reference comparison

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.23.0
• Component/s: camel-core
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Hiroaki Yoshida
• Created: 15/Aug/18 00:10
• Updated: 15/Aug/18 06:44
• Resolved: 15/Aug/18 06:44

Description

FindBugs-3.0.1 (http://findbugs.sourceforge.net/) reported 2 RC_REF_COMPARISON warnings on master:

H C RC: Suspicious comparison of Integer references in org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(Exchange)  At Throttler.java:[line 312]
H C RC: Suspicious comparison of Integer references in org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(DelayQueue, Exchange, Integer)  At Throttler.java:[line 360]

The description of the bug is as follows:

RC: Suspicious reference comparison (RC_REF_COMPARISON)
This method compares two reference values using the == or != operator, where the correct way to compare instances of this type is generally with the equals() method. It is possible to create distinct instances that are equal but do not compare as == since they are different objects. Examples of classes which should generally not be compared by reference are java.lang.Integer, java.lang.Float, etc.
http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON

Issue Links

• links to: GitHub Pull Request #2472
• links to: GitHub Pull Request #2472