[CAMEL-12635] Potential NPE in CamelEndpointDetails.hashCode method

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.22.0
• Fix Version/s: 2.22.1, 2.23.0
• Component/s: tooling
• Estimated Complexity: Novice
• Assignee: Onder Sezgin
• Reporter: Aurélien Pupier
• Created: 10/Jul/18 13:51
• Updated: 11/Jul/18 13:55
• Resolved: 11/Jul/18 13:55

Description

in case className is null, there is an NPE

 

java.lang.NullPointerException
at org.apache.camel.parser.model.CamelEndpointDetails.hashCode(CamelEndpointDetails.java:153)
at java.util.HashMap.hash(HashMap.java:338)
at java.util.HashMap.put(HashMap.java:611)
at com.github.cameltooling.lsp.internal.CamelTextDocumentService.didSave(CamelTextDocumentService.java:223)

it is also possible with endpointURi but i think that endpointURi is always not null (but maybe worth checking for non null in hashCode method