[CAMEL-12589] Surviving Header AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE affects following aggregations

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.21.0, 2.21.1
• Fix Version/s: 2.21.2, 2.22.1, 2.23.0
• Component/s: camel-core
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Gianandrea Rigoni
• Created: 19/Jun/18 14:23
• Updated: 30/Jul/18 11:46
• Resolved: 05/Jul/18 12:57

Description

When AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE is once set true it survives current aggregation processing and affects in unexpected way following aggregation by triggering "forceCompletionOfAllGroups()" again

in next code snippet might be needed some additional handling when the header is true:

protected void doProcess(Exchange exchange) throws Exception {
...
        // check for the special header to force completion of all groups (inclusive of the message)
        boolean completeAllGroupsInclusive = exchange.getIn().getHeader(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE, false, boolean.class);
        if (completeAllGroupsInclusive) {
            forceCompletionOfAllGroups();
        }
...

this consideration is made by analysing similar behavior and lifecycle of header AGGREGATION_COMPLETE_ALL_GROUPS:

private List<Exchange> doAggregation(String key, Exchange newExchange) throws CamelExchangeException {
...
...        
        // check for the special exchange property to force completion of all groups
        boolean completeAllGroups = answer.getProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS, false, boolean.class);
        if (completeAllGroups) {
            // remove the exchange property so we do not complete again
            answer.removeProperty(Exchange.AGGREGATION_COMPLETE_ALL_GROUPS);
            forceCompletionOfAllGroups();
        } else if (isCompletionOnNewCorrelationGroup() && originalExchange == null) {
            // its a new group so force complete of all existing groups
            forceCompletionOfAllGroups();
        }
...