[CAMEL-12493] Make additional HL7 Type Converters optional - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.21.0
Fix Version/s: 2.21.2, 2.22.0
Component/s: camel-hl7
Labels:
None

Estimated Complexity:
Unknown

Description

In Camel 2.21.0, HL7-version/event-specific type converters were added to camel-hl7. IMHO this was a bad idea:

it transitively pulls in all HL7 structure libraries, regardless whether you need them in your application or not. That's nearly 10MB. Btw, type converters for the newer HL7 versions 2.7, 2.8, 2.8.1 were simply disregarded, which would have gifted you with another ~ 7.5MB.
manually excluding one or more of them causes the AnnotationTypeConverterLoader to throw ugly NoClassDefFoundError stack traces in the log
the component documentation states that you have to manually add structure library dependencies (the way it should be, really)

Proposal: remove these type converters. I think it's acceptable to do a simple type cast in a processor or add a manual convertBodyTo(HL7Class) in the route instead.

Opinions? (I'm happy to provide a PR )