[CAMEL-11898] camel-spring-ws - Attachments are lost

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.19.3
• Fix Version/s: 2.19.4, 2.20.1, 2.21.0
• Component/s: camel-spring-ws
• Estimated Complexity: Novice
• Assignee: Claus Ibsen
• Reporter: Richard Groote
• Created: 12/Oct/17 09:22
• Updated: 12/Oct/17 14:00
• Resolved: 12/Oct/17 14:00

Description

The below scenario is failing in 2.19.3 and was working 2.14.0.
May be we're doing something wrong but i cannot find out where the problem is originated.
Any help would be appreciated

Some debug information

• I've debugged the code in 2.14.0 and 2.19.3 in the 'old' ConvertBodyProcessor the out was put back on the DefaultMessage
• In the SpringWebserviceConsumer (2.19.3) there is no out message after the processor. The in message is present including the attachments.
• In the BasicMessageFilter#filterConsumer(2.19.3) the out is read without checking hasOut(). I think the solution is to look if there is out available, when not available using the in message

Scenario

• Sending a request to a soap service in this case the spring-ws component
• A bean is responsible for retrieving some information and attachments
• The soap response no longer contains the attachment

Below is part of spring configuration
<camel:from uri="spring-ws:uri:/contextPath/soapServices?endpointMapping=#endpointMapping"/>
<camel:to uri="bean:someBean?method=onMessage('myMethod')" />
<camel:convertBodyTo type="java.lang.String"/>

Snippet of the bean

exchange.getOut().copyFrom(exchange.getIn());
exchange.getOut().setHeader(Exchange.CHARSET_NAME, CamelConstants.DEFAULT_CHARACTER_SET);
exchange.getOut().setBody(response.getResponse());
exchange.getOut().addAttachment(id, attachment.getAttachment());

Issue Links

• links to: GitHub Pull Request #2030