Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-11553

Upgrade to Brave 4

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.19.1
    • 2.20.0
    • camel-zipkin
    • None
    • Novice

    Description

      It would be nice to have up to date library not using deprecated code, because:
      Brave v. 4 allows you to use brave.Tracing so one can easily register https://github.com/openzipkin/brave/tree/master/context/slf4j which allows you to have in each log line info about spans:

      2017-07-17 17:44:08.526  INFO [proxy,b805c5edbe362a7c,b805c5edbe362a7c,true]
      

      Then it is easy to copy and use span id to zipkin UI in case of debugging. (btw currently there is Long value of span instead of Hexadecimal printed).

      There is possibility to overlap with version 3 and 4 -> https://github.com/openzipkin/brave/tree/master/brave#upgrading-from-brave-3 so this could be good start.
      Also brave.sampler.Sampler should be used in stead of com.github.kristofa.brave.Sampler

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            acosentino Andrea Cosentino
            cipous Radek Mensik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment