[CAMEL-11348] Small Performance optimization in RestConsumerContextPathMatcher

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.19.0
• Fix Version/s: 2.20.0
• Component/s: camel-core, rest
• Estimated Complexity: Novice
• Assignee: Andrea Cosentino
• Reporter: Zoltan Farkas
• Created: 26/May/17 20:03
• Updated: 06/Jun/17 09:47
• Resolved: 06/Jun/17 08:59

Description

at https://github.com/apache/camel/blob/57711e2696c32ef3ab99ad4ccc62f09bfda2ab40/camel-core/src/main/java/org/apache/camel/support/RestConsumerContextPathMatcher.java#L97 :

        String p1 = requestPath.toLowerCase(Locale.ENGLISH);
        String p2 = consumerPath.toLowerCase(Locale.ENGLISH);

        if (p1.equals(p2)) {
            return true;
        }

        if (matchOnUriPrefix && p1.startsWith(p2)) {
            return true;
        }

        return false;

we can improve to:

    if (requestPath.equalsIgnoreCase(consumerPath)) {
      return true;
    }
    return matchOnUriPrefix && requestPath.regionMatches(true, 0, consumerPath, 0, consumerPath.length());

Issue Links

• links to: GitHub Pull Request #1739