[CAMEL-10640] Custom AsyncHttpClientConfig not used in WsEndpoint - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.18.1
Fix Version/s: 2.18.2, 2.19.0
Component/s: camel-ahc-ws
Labels:
None

Patch Info:

Patch Available
Estimated Complexity:
Novice

Description

Provided custom AsyncHttpClientConfig is not used by WsEndpoint.java.

Current implementation:

WsEndpoint.java:109

    protected AsyncHttpClient createClient(AsyncHttpClientConfig config) {
        AsyncHttpClient client;
        if (config == null) {
            config = new DefaultAsyncHttpClientConfig.Builder().build();
            client = new DefaultAsyncHttpClient(config);
        } else {
            client = new DefaultAsyncHttpClient();
        }
        return client;
    }

Expected implementation:

WsEndpoint.java:109

    protected AsyncHttpClient createClient(AsyncHttpClientConfig config) {
        AsyncHttpClient client;
        if (config == null) {
            config = new DefaultAsyncHttpClientConfig.Builder().build();
            client = new DefaultAsyncHttpClient(config);
        } else {
            client = new DefaultAsyncHttpClient(config);
        }
        return client;
    }