[CAMEL-10568] SftpChangedExclusiveReadLockStrategy integer overflow

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.18.0
• Fix Version/s: 2.17.5, 2.18.2, 2.19.0
• Component/s: camel-sftp
• Estimated Complexity: Novice
• Assignee: Claus Ibsen
• Reporter: Adam Campbell
• Created: 07/Dec/16 22:29
• Updated: 08/Dec/16 14:17
• Resolved: 08/Dec/16 14:15

Description

It looks like CAMEL-9820 has not resolved SFTP readLockMinAge functionality.

When I run the latest version, I get a new last modified time as negative. I think this is because both types are int so it is performing the calculation as an int and then converting it to long.

It should work if this line:

newLastModified = f.getAttrs().getMTime() * 1000;

Is changed to:

newLastModified = f.getAttrs().getMTime() * 1000L;

TRACE o.a.c.c.f.r.s.SftpChangedExclusiveReadLockStrategy - List files outgoing/Promo/dev/test.dat found 1 files
TRACE o.a.c.c.f.r.s.SftpChangedExclusiveReadLockStrategy - Previous last modified: -9223372036854775808, new last modified: -616826120
TRACE o.a.c.c.f.r.s.SftpChangedExclusiveReadLockStrategy - Previous length: -9223372036854775808, new length: 12921172
TRACE o.a.c.c.f.r.s.SftpChangedExclusiveReadLockStrategy - New older than threshold: 1481147995902
TRACE o.a.c.c.f.r.s.SftpChangedExclusiveReadLockStrategy - Read lock acquired.

Issue Links

• links to: GitHub Pull Request #1337