[CAMEL-10454] Unclear piece in IdempotentConsumer.java

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.17.4, 2.18.1, 2.19.0
• Component/s: camel-core
• Estimated Complexity: Novice
• Assignee: Andrea Cosentino
• Reporter: Boris Treukhov
• Created: 08/Nov/16 15:04
• Updated: 16/Nov/16 01:27
• Resolved: 16/Nov/16 01:27

Description

Current implementation of IdempotentConsumer.java has very strange check on whether IdempotentRepository contains the key - if it's ExchangeIdempotentRepository then the result of "contains()" check is not inverted(i.e. there is no NOT operator), while for other types of IdempotentRepository it IS inverted with "!".

// check if we already have the key
if (idempotentRepository instanceof ExchangeIdempotentRepository)

{ newKey = ((ExchangeIdempotentRepository<String>) idempotentRepository).contains(exchange, messageId); }

else

{ newKey = !idempotentRepository.contains(messageId); }

Issue Links

• links to: GitHub Pull Request #1271