Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-995

Sort transpose rules might fall in an infinite loop

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.0
    • Fix Version/s: 1.6.0
    • Component/s: core
    • Labels:
      None

      Description

      CALCITE-987 introduced the RelMdMaxRowCount metadata provider. By default, RelMdMaxRowCount returns Double.MAX, which is causing some infinite loops in the current test suite, as Sort will continue being pushed below Union/Join (if the estimate row count for Union/Join is Double.MAX).

      I propose to return null by default if we cannot get the maximum number of rows, which makes more sense and allows catching this issue.

        Issue Links

          Activity

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/3e49bc4 .
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Julian Hyde, I realized CALCITE-987 had broken some tests after I pushed it to master, so I have pushed this fix quickly.

          If you think we should fix it in another way, we can open a follow-up JIRA. Thanks

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Julian Hyde , I realized CALCITE-987 had broken some tests after I pushed it to master, so I have pushed this fix quickly. If you think we should fix it in another way, we can open a follow-up JIRA. Thanks
          Hide
          julianhyde Julian Hyde added a comment -

          I made some review comments in CALCITE-987. Let's discuss there.

          Show
          julianhyde Julian Hyde added a comment - I made some review comments in CALCITE-987 . Let's discuss there.
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.6.0 (2016-01-22).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

            People

            • Assignee:
              jcamachorodriguez Jesus Camacho Rodriguez
              Reporter:
              jcamachorodriguez Jesus Camacho Rodriguez
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development