Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-977

Make the Executor (for constant reduction) configurable in FrameworkConfig

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:

      Description

      This comes from a commit in Drill's forked Calcite (https://github.com/dremio/calcite/commit/15d645f15c526ebed06a80b4101faf765bfe1d70)

      Make the constant expression Executor configurable in FrameworkConfig. This will allow the Framework.Planner to use a configured constant expression executor, in stead of the default executor.

        Activity

        Hide
        jni Jinfeng Ni added a comment -

        Jason Altekruse, could you please see if this commit could be picked into Calcite master directly, or need some additional work?

        Show
        jni Jinfeng Ni added a comment - Jason Altekruse , could you please see if this commit could be picked into Calcite master directly, or need some additional work?
        Hide
        julianhyde Julian Hyde added a comment -

        For IP hygiene, we need a PR. Simply referencing a github URL does not constitute a code donation to Apache.

        Show
        julianhyde Julian Hyde added a comment - For IP hygiene, we need a PR. Simply referencing a github URL does not constitute a code donation to Apache.
        Hide
        jaltekruse Jason Altekruse added a comment -

        Pull request for the changes: https://github.com/apache/calcite/pull/182

        Show
        jaltekruse Jason Altekruse added a comment - Pull request for the changes: https://github.com/apache/calcite/pull/182
        Hide
        jaltekruse Jason Altekruse added a comment -

        Julian Hyde Not quite sure how to mark this as reviewable with the workflow on JIRA as it is set up, do you generally just mention reviewers in the discussion?

        Show
        jaltekruse Jason Altekruse added a comment - Julian Hyde Not quite sure how to mark this as reviewable with the workflow on JIRA as it is set up, do you generally just mention reviewers in the discussion?
        Hide
        jni Jinfeng Ni added a comment -

        Jason, would you please also apply your patch on top of Drill's forked Calcite, and re-run Drill's pre-commit test, to make sure that the patch works for the Drill side as well, if you have not done that?

        Thanks!

        Show
        jni Jinfeng Ni added a comment - Jason, would you please also apply your patch on top of Drill's forked Calcite, and re-run Drill's pre-commit test, to make sure that the patch works for the Drill side as well, if you have not done that? Thanks!
        Hide
        jaltekruse Jason Altekruse added a comment -

        I had not done this, the patch applied cleanly and is already in that branch so I figured it was tested. I will try to re-apply to see if it changes anything.

        Show
        jaltekruse Jason Altekruse added a comment - I had not done this, the patch applied cleanly and is already in that branch so I figured it was tested. I will try to re-apply to see if it changes anything.
        Hide
        julianhyde Julian Hyde added a comment -

        Jason Altekruse, Yes, you just did it. I will review your patch.

        Show
        julianhyde Julian Hyde added a comment - Jason Altekruse , Yes, you just did it. I will review your patch.
        Hide
        jaltekruse Jason Altekruse added a comment -

        Julian Hyde thanks!

        Show
        jaltekruse Jason Altekruse added a comment - Julian Hyde thanks!
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/5323d8d4 .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.6.0 (2016-01-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

          People

          • Assignee:
            jaltekruse Jason Altekruse
            Reporter:
            jni Jinfeng Ni
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development