Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-975

PlannerImpl.validate() should return validated row type

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:

      Description

      This comes from a commit in Drill's forked Calcite. (https://github.com/dremio/calcite/commit/84bae715310d8684ac545f0a4f17c86d19e502a4)

      PlannerImpl.validate() only returns SqlNode after the input SqlNode goes through SqlValidator check, and it does not return the validated rowtype. This is different from the regular code path in CalcitePrepareImpl, where validate rowtype is passed into ParseResult/ConvertResult.

      We should provide a way in PlannerImpl such that the validated rowType is accessible.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.6.0 (2016-01-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/0045e01f .
        Hide
        julianhyde Julian Hyde added a comment -

        +1 Go ahead and commit.

        Show
        julianhyde Julian Hyde added a comment - +1 Go ahead and commit.
        Hide
        jni Jinfeng Ni added a comment -

        Submit PR at https://github.com/apache/calcite/pull/184.

        Julian Hyde, could you please review this small patch? Thanks!

        Show
        jni Jinfeng Ni added a comment - Submit PR at https://github.com/apache/calcite/pull/184 . Julian Hyde , could you please review this small patch? Thanks!
        Hide
        jni Jinfeng Ni added a comment -

        I'll submit a PR after done with code rebase / revise.

        Show
        jni Jinfeng Ni added a comment - I'll submit a PR after done with code rebase / revise.

          People

          • Assignee:
            jni Jinfeng Ni
            Reporter:
            jni Jinfeng Ni
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development