Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-964

Rename "timezone" connection property to "timeZone"

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Rename "timezone" connection property to "timeZone", to be consistent with java.util.TimeZone (two words in camel case). Also rename CalciteConnectionProperty.TIMEZONE and BuiltInConnectionProperty.TIMEZONE to TIME_ZONE.

      ConnectionConfig.timeZone() is already OK.

      Connect string properties are matched case-insensitively, and so "jdbc:calcite:timezone=gmt+3" will continue to work. So will "timeZone", "TIME_ZONE", "TIMEZONE".

        Activity

        Show
        julianhyde Julian Hyde added a comment - Josh Elser Can you please review my proposed fix in https://github.com/julianhyde/calcite/commit/1e4cbfbac756b1ba8056f9c6285f252a921ce31d .
        Hide
        elserj Josh Elser added a comment -

        LGTM. Thanks for adding the comment to JdbcMetaTest.java.

        Show
        elserj Josh Elser added a comment - LGTM. Thanks for adding the comment to JdbcMetaTest.java.
        Hide
        julianhyde Julian Hyde added a comment - - edited
        Show
        julianhyde Julian Hyde added a comment - - edited Thanks for the review, Josh Elser ! Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/bb333e20 .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.6.0 (2016-01-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            julianhyde Julian Hyde
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development