Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-959

Add description to SortProjectTransposeRule's constructor

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Since the default instance only matches LogicalProject.class (and it would be problematic to match Project.class), it might be nice to provide a constructor that takes an extra description string to allow users to have another instance of this rule in addition to the default one.

      1. CALCITE-959.patch
        0.9 kB
        Maryann Xue

        Activity

        Hide
        maryannxue Maryann Xue added a comment -

        Would you mind reviewing this patch, Julian Hyde?

        Show
        maryannxue Maryann Xue added a comment - Would you mind reviewing this patch, Julian Hyde ?
        Hide
        julianhyde Julian Hyde added a comment -

        I think you should deprecate the original constructor (mark it 'to be removed before 2.0), and add a simple javadoc comment to the new constructor. With those changes +1, go ahead and commit. (You don't need the " (Maryann Xue)" commit suffix now you're a committer.)

        Show
        julianhyde Julian Hyde added a comment - I think you should deprecate the original constructor (mark it 'to be removed before 2.0), and add a simple javadoc comment to the new constructor. With those changes +1, go ahead and commit. (You don't need the " (Maryann Xue)" commit suffix now you're a committer.)
        Hide
        maryannxue Maryann Xue added a comment -
        Show
        maryannxue Maryann Xue added a comment - Thank you, Julian Hyde , for the comments! Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/f22ecfa .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.6.0 (2016-01-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

          People

          • Assignee:
            maryannxue Maryann Xue
            Reporter:
            maryannxue Maryann Xue
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development