[CALCITE-955] Litmus, continuation-passing style applied to validation methods

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 06/Nov/15 01:57
• Updated: 21/Jan/16 22:20
• Resolved: 11/Jan/16 04:51

Description

Calcite has several methods that check internal consistency that have a 'boolean fail' argument indicating whether the method should throw or just return false if a consistency error is detected.

We propose to add a class Litmus:

interface Litmus {
  boolean fail(String message);
  boolean succeed();
}

and replace those boolean fail with Litmus litmus, so that the caller can determine policy on how to handle failures.

Methods affected include:

• RelNode.isValid(boolean)