Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-955

Litmus, continuation-passing style applied to validation methods

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.6.0
        • Component/s: None
        • Labels:
          None

          Description

          Calcite has several methods that check internal consistency that have a 'boolean fail' argument indicating whether the method should throw or just return false if a consistency error is detected.

          We propose to add a class Litmus:

          interface Litmus {
  boolean fail(String message);
  boolean succeed();
}

          and replace those boolean fail with Litmus litmus, so that the caller can determine policy on how to handle failures.

          Methods affected include:

          • RelNode.isValid(boolean)

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/9a52b5ed.

            Show
            julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/9a52b5ed .
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Resolved in release 1.6.0 (2016-01-22).

            Show
            julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                julianhyde Julian Hyde
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development