Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-935

Improve how ReduceExpressionsRule handles duplicate constraints

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • None
    • None

    Description

      We need to improve ReduceExpressionRule to deal with multiple "equals to literal" in predicate. In ReduceExpressionRule.java, L396-397:

      final ImmutableMap<RexNode, RexLiteral> constants =
             predicateConstants(predicates);

      The query is

      select * from src where (key='12' and key is null);

      Here 'key' is a string type and it is one of the columns of 'src' table.

      Then we will have predicates

      [=($0, '12'), isnull($0)]

      which is the input of the
      predicateConstants, and the function will return "{$0='12'}"

      Attachments

        1. CALCITE-935.01.patch
          5 kB
          Pengcheng Xiong

        Activity

          People

            pxiong Pengcheng Xiong
            pxiong Pengcheng Xiong
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: