Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.5.0
-
Component/s: None
-
Labels:None
Description
The traitSet of the new Sort for Join's right child should be replaced with rightCollation.
newRightInput = sort.copy(sort.getTraitSet(), join.getRight(), rightCollation,
sort.offset, sort.fetch);
Issue Links
- is related to
-
CALCITE-892
Implement SortJoinTransposeRule
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Maryann Xue, the change makes sense; I just checked the Sort operator constructor and we enforce (via assertion) that the traits contain the given collation, so I'm wondering why we didn't catch this?
Jesus Camacho Rodriguez The assertion is to test that the traitSet either does not contain the RelCollation trait at all or if it does have a RelCollation trait it must be equal to the "collation" parameter passed to the constructor. Meanwhile the default traitSet in the default "tester" does not have collation trait, which means the assert would succeed with the first condition.
So you can see from the new test case in this patch that I created a customized "tester" to include the collation trait into the "cluster" so that the assertion would go to its second condition.
+1
Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/b8599379. Thanks for the patch, Maryann Xue!
Resolved in release 1.5.0 (2015-11-10)
Jesus Camacho Rodriguez and Julian Hyde, would you mind reviewing this patch?