Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-917

Add support for EXPLAIN PLAN AS JSON

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.11.0
        • Component/s: core
        • Labels:

          Description

          Explain plan currently supports outputting text and xml. Let's add an option to explain plan "AS JSON". Drill will definitely plug into this. Other systems could as well.

            Issue Links

            is depended upon by

            Improvement - An improvement or enhancement to an existing feature or task. DRILL-3919 Explain should only return text plan by default

            • Major - Major loss of function.
            • Open

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              michaelmior Michael Mior added a comment -

              I thought this would be a fun one to try to tackle to start getting familiar with Calcite. So far I managed to extend the grammar to include "AS JSON" and I'm just working on actually dumping the JSON output. WIP at https://github.com/michaelmior/calcite/tree/917-explain-json

              Show
              michaelmior Michael Mior added a comment - I thought this would be a fun one to try to tackle to start getting familiar with Calcite. So far I managed to extend the grammar to include "AS JSON" and I'm just working on actually dumping the JSON output. WIP at https://github.com/michaelmior/calcite/tree/917-explain-json
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Michael Mior, Is this ready to submit? Can I help?

              Show
              julianhyde Julian Hyde added a comment - Michael Mior , Is this ready to submit? Can I help?
              Hide
              Permalink
              michaelmior Michael Mior added a comment -

              Sorry, I had kind of forgotten about this. Here's a pull request. If you could review, that would be great.

              https://github.com/apache/calcite/pull/295

              Show
              michaelmior Michael Mior added a comment - Sorry, I had kind of forgotten about this. Here's a pull request. If you could review, that would be great. https://github.com/apache/calcite/pull/295
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Yes, I'll review. It will probably be after 1.10.

              Show
              julianhyde Julian Hyde added a comment - Yes, I'll review. It will probably be after 1.10.
              Hide
              Permalink
              julianhyde Julian Hyde added a comment - - edited

              Michael Mior, Looks good. I added some fix ups (see https://github.com/julianhyde/calcite/commit/3bbe9ef382811a912df171317fc840360542271b; mainly to combine boolean asXml and boolean asJson into enum SqlExplainFormat) and if you're OK I'll squash and commit after 1.10.

              Show
              julianhyde Julian Hyde added a comment - - edited Michael Mior , Looks good. I added some fix ups (see https://github.com/julianhyde/calcite/commit/3bbe9ef382811a912df171317fc840360542271b ; mainly to combine boolean asXml and boolean asJson into enum SqlExplainFormat ) and if you're OK I'll squash and commit after 1.10.
              Hide
              Permalink
              michaelmior Michael Mior added a comment -

              That's great! Something I thought about and probably should have done myself. Thanks and thanks for adding the test as well Looks good to me.

              Show
              michaelmior Michael Mior added a comment - That's great! Something I thought about and probably should have done myself. Thanks and thanks for adding the test as well Looks good to me.
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/accc059c.

              Show
              julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/accc059c .
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Resolved in release 1.11.0 (2017-01-11).

              Show
              julianhyde Julian Hyde added a comment - Resolved in release 1.11.0 (2017-01-11).

                People

                • Assignee:
                  michaelmior Michael Mior
                  Reporter:
                  jnadeau Jacques Nadeau
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development