[CALCITE-915] Tests do not unset ThreadLocal values on exit

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 08/Oct/15 23:01
• Updated: 21/Jan/16 22:20
• Resolved: 11/Jan/16 04:51

Description

A few tests give different results if run as part of the suite than if run individually. The reason is that previous tests that share the same ThreadLocal instances had not set the value back on exit.

Add a class TryThreadLocal extends ThreadLocal with a 'push' method that returns a Closeable memo that can be used in a try-with-resources block. The memo remembers the previous value and assigned that when close is called.