Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-908

Bump protobuf dependency to protobuf-3.0.0-beta-1

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.0
    • Component/s: avatica
    • Labels:
      None

      Description

      Jan Van Besien noticed that we're using a slightly outdated protobuf3 build. We should switch to the newer beta release instead of the alpha.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          And also update site/_docs/howto.md.

          Show
          julianhyde Julian Hyde added a comment - And also update site/_docs/howto.md.
          Hide
          elserj Josh Elser added a comment -

          Good point, Julian.

          Looking at the release page:

          The static PARSER in each generated message is deprecated, and it will
          be removed in a future release. A static parser() getter is generated
          for each message type instead.

          This is also important to fix. I used this field to tie the POJOs to the protobuf classes.

          Proto3 JSON is supported in several languages (fully supported in C++
          and Java, partially supported in Ruby/C#). The JSON spec is defined in
          the proto3 language guide:

          https://developers.google.com/protocol-buffers/docs/proto3#json

          Looks like we can also start trying out the JSON serialization (instead of the binary serialization) which will help in readability/debugging of the stuff over the wire.

          Show
          elserj Josh Elser added a comment - Good point, Julian. Looking at the release page: The static PARSER in each generated message is deprecated, and it will be removed in a future release. A static parser() getter is generated for each message type instead. This is also important to fix. I used this field to tie the POJOs to the protobuf classes. Proto3 JSON is supported in several languages (fully supported in C++ and Java, partially supported in Ruby/C#). The JSON spec is defined in the proto3 language guide: https://developers.google.com/protocol-buffers/docs/proto3#json Looks like we can also start trying out the JSON serialization (instead of the binary serialization) which will help in readability/debugging of the stuff over the wire.
          Hide
          julianhyde Julian Hyde added a comment -

          This patch no longer merges. And neither does CALCITE-912, which also modifies generated protobuf code. Bruno Dumon and Josh Elser please collaborate to sequence your patches and email the dev list when you have a plan.

          Show
          julianhyde Julian Hyde added a comment - This patch no longer merges. And neither does CALCITE-912 , which also modifies generated protobuf code. Bruno Dumon and Josh Elser please collaborate to sequence your patches and email the dev list when you have a plan.
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/86610552 . Thanks for the PR, Josh Elser !
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Resolved in release 1.5.0 (2015-11-10)

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.5.0 (2015-11-10)

            People

            • Assignee:
              elserj Josh Elser
              Reporter:
              elserj Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development