Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-897

Enable debugging using "-Dcalcite.debug"

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.5.0
        • Component/s: None
        • Labels:
          None

          Description

          The documentation on https://calcite.incubator.apache.org/docs/howto.html says

          -Dcalcite.debug prints extra debugging information to stdout.

          It has to be -Dcalcite.debug=true.

          Or alternatively the code has to be updated to reflect the documentation, which might be even better in this case.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            What would be the effect of "-Dcalcite.debug"? Would the system property "calcite.debug" be set to the empty string? If so I think we could change the code to accept that and treat it as "true".

            Show
            julianhyde Julian Hyde added a comment - What would be the effect of "-Dcalcite.debug"? Would the system property "calcite.debug" be set to the empty string? If so I think we could change the code to accept that and treat it as "true".
            Hide
            Permalink
            janvanbesien Jan Van Besien added a comment -

            Yes, it would be the empty string. So it could be

            public static final boolean DEBUG = System.getProperty("calcite.debug") != null;

            Or maybe better if you still want to allow to explicitly set it to false.

            public static final boolean DEBUG = System.getProperty("calcite.debug") != null && !"false".equalsIgnoreCase(System.getProperty("calcite.debug"));
            Show
            janvanbesien Jan Van Besien added a comment - Yes, it would be the empty string. So it could be public static final boolean DEBUG = System .getProperty( "calcite.debug" ) != null ; Or maybe better if you still want to allow to explicitly set it to false. public static final boolean DEBUG = System .getProperty( "calcite.debug" ) != null && ! " false " .equalsIgnoreCase( System .getProperty( "calcite.debug" ));
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Working on this in https://github.com/julianhyde/incubator-calcite/tree/828-rule-builder. Will commit to master shortly.

            Show
            julianhyde Julian Hyde added a comment - Working on this in https://github.com/julianhyde/incubator-calcite/tree/828-rule-builder . Will commit to master shortly.
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/a1e0b006.

            Show
            julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/a1e0b006 .
            Hide
            Permalink
            jcamachorodriguez Jesus Camacho Rodriguez added a comment -

            Resolved in release 1.5.0 (2015-11-10)

            Show
            jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.5.0 (2015-11-10)
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Further fix in http://git-wip-us.apache.org/repos/asf/calcite/commit/77e6f49c (will be in 1.6).

            Show
            julianhyde Julian Hyde added a comment - Further fix in http://git-wip-us.apache.org/repos/asf/calcite/commit/77e6f49c (will be in 1.6).

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                janvanbesien Jan Van Besien
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development