Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.0
    • Component/s: core
    • Labels:
      None

      Description

      Specifically these statements:

      ALTER scope RESET `option name`
      ALTER scope RESET ALL
      RESET `option name`
      RESET ALL
      SET `option name`
      

      Additional tasks:
      + Make scope optional
      + Option name should be a CompoundIdentifier

      1. CALCITE-823-0.patch
        10 kB
        Sudheesh Katkam

        Issue Links

          Activity

          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Resolved in release 1.5.0 (2015-11-10)

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.5.0 (2015-11-10)
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/25b28607 . Thanks for the patch, Sudheesh Katkam !
          Hide
          sudheeshkatkam Sudheesh Katkam added a comment -

          Thank you for your comments. I updated the pull request.

          Show
          sudheeshkatkam Sudheesh Katkam added a comment - Thank you for your comments. I updated the pull request.
          Hide
          julianhyde Julian Hyde added a comment - - edited

          I wouldn't necessarily do what Postgres does. But I see that Oracle uses RESET also.

          I made a few comments on the pull request - can you fix these? Also please modify reference.md. With those changes, patch looks good.

          Show
          julianhyde Julian Hyde added a comment - - edited I wouldn't necessarily do what Postgres does. But I see that Oracle uses RESET also. I made a few comments on the pull request - can you fix these? Also please modify reference.md. With those changes, patch looks good.
          Hide
          sudheeshkatkam Sudheesh Katkam added a comment -

          Attached a patch. I also opened a pull request. I am unable to change the status of the JIRA to REVIEWABLE or assign the JIRA to myself.

          I made 'ALTER scope' part optional so implementors can assume a default scope (for Drill, we assume SESSION).

          From PostgreSQL, it looks like RESET (rather than UNSET) is available.

          Show
          sudheeshkatkam Sudheesh Katkam added a comment - Attached a patch. I also opened a pull request . I am unable to change the status of the JIRA to REVIEWABLE or assign the JIRA to myself. I made 'ALTER scope' part optional so implementors can assume a default scope (for Drill, we assume SESSION). From PostgreSQL, it looks like RESET (rather than UNSET) is available.
          Hide
          julianhyde Julian Hyde added a comment -

          Also, consider using 'unset' rather than 'reset'. I think 'unset' is more typical in other programming languages. (Consider Perl and bash; they both have both unset and reset, and in each, reset does something entirely different.)

          Show
          julianhyde Julian Hyde added a comment - Also, consider using 'unset' rather than 'reset'. I think 'unset' is more typical in other programming languages. (Consider Perl and bash; they both have both unset and reset, and in each, reset does something entirely different.)
          Hide
          julianhyde Julian Hyde added a comment -

          SET and RESET without a preceding ALTER? How about 'ALTER SESSION SET ...'

          Show
          julianhyde Julian Hyde added a comment - SET and RESET without a preceding ALTER? How about 'ALTER SESSION SET ...'

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              sudheeshkatkam Sudheesh Katkam
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development