Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-813

Upgrade updateCount, maxRows from int to long

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: avatica
    • Labels:
      None

      Description

      JDK 1.8 introduced methods exposing updateCount and maxRows as long values, where previously they were int values. The methods are:

      • long Statement.executeLargeUpdate(String)
      • long Statement.getLargeUpdateCount()
      • long Statement.getLargeMaxRows()
      • void Statement.setLargeMaxRows(long)

      AvaticaStatement should implement these methods.

      This will require changing corresponding fields: ResultSetResponse.updateCount, PrepareAndExecuteRequest.maxRowCount, ExecuteRequest.maxRowCount, PrepareRequest.maxRowCount. Also FetchRequest.offset.

      But note that Statement.setFetchSize(int) and .getFetchSize() remain int methods, and FetchRequest.fetchMaxRowCount remains an int.

      JdbcMeta should use these methods in the underlying JDBC driver, and if they throw UnsupportedOperationException, fall back to the int version.

        Issue Links

          Activity

          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/c818d50b .
          Hide
          jnadeau Jacques Nadeau added a comment -

          Resolved in release 1.4.0-incubating (2015-08-23)

          Show
          jnadeau Jacques Nadeau added a comment - Resolved in release 1.4.0-incubating (2015-08-23)

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development