Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0-incubating
    • Fix Version/s: 1.5.0
    • Component/s: core
    • Labels:
      None

      Description

      Serializing a RelNode to JSON using org.apache.calcite.rel.externalize.RelJsonWriter outputs invalid JSON. JSON requires that key names be quoted, but the output uses unquoted key names. This makes it impossible to interoperate with tools that require valid JSON.

        Issue Links

          Activity

          Hide
          mprudhom Marc Prud'hommeaux added a comment -

          This appears to be a problem with org.apache.calcite.util.JsonBuilder, and so it affects other components that rely on this class.

          Show
          mprudhom Marc Prud'hommeaux added a comment - This appears to be a problem with org.apache.calcite.util.JsonBuilder, and so it affects other components that rely on this class.
          Hide
          julianhyde Julian Hyde added a comment -

          Agreed, we should quote keys.

          Show
          julianhyde Julian Hyde added a comment - Agreed, we should quote keys.
          Hide
          mprudhom Marc Prud'hommeaux added a comment -

          I submitted a PR for this at: https://github.com/apache/incubator-calcite/pull/116

          Let me know if you'd prefer it in the form of a patch.

          Show
          mprudhom Marc Prud'hommeaux added a comment - I submitted a PR for this at: https://github.com/apache/incubator-calcite/pull/116 Let me know if you'd prefer it in the form of a patch.
          Hide
          julianhyde Julian Hyde added a comment -

          Pull request is fine – preferred to patch, in fact.

          Running the test suite and getting breakages in MongoAdapterIT. Working on a fix.

          Show
          julianhyde Julian Hyde added a comment - Pull request is fine – preferred to patch, in fact. Running the test suite and getting breakages in MongoAdapterIT. Working on a fix.
          Hide
          julianhyde Julian Hyde added a comment -

          I have committed to my new-master branch as https://github.com/julianhyde/incubator-calcite/commit/e1a707306ba463463c79bb046fdcedd4aee10cbf, incorporating my fixes to the Mongo test. I will commit to master and close this case when commits re-open after release 1.4.

          Show
          julianhyde Julian Hyde added a comment - I have committed to my new-master branch as https://github.com/julianhyde/incubator-calcite/commit/e1a707306ba463463c79bb046fdcedd4aee10cbf , incorporating my fixes to the Mongo test. I will commit to master and close this case when commits re-open after release 1.4.
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/54249d04 . Thanks for the patch, Marc Prud'hommeaux !
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Resolved in release 1.5.0 (2015-11-10)

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.5.0 (2015-11-10)

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              mprudhom Marc Prud'hommeaux
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development