Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-794

Detect cycles when computing statistics

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.6.0
    • None
    • None

    Description

      The graph of RelNodes is allowed to be cyclic. This causes problems when evaluating certain metadata, for example RelMetataQuery.areColumnsUnique. While computing the value for RelNode r, it might recurse through say a Project and hit r again. This causes a stack overflow.

      We solve this by adding a map or set of active RelNodes. The map is stored within RelMetadataQuery, which can now be instantiated, and its methods are no longer static. The first call should instantiate a RelMetadataQuery, but all subsequent calls for metadata (perhaps several kinds of metadata) will use the same RelMetadataQuery instance, hence the same map.

      Also add a RelMetadataQuery argument to the static "handler" methods in RelMdColumnUniqueness and similar classes.

      This is a breaking change for people who have written a metadata handler, and might be subtle to detect, because the methods are invoked via reflection.

      For code that is just using RelMetadataQuery methods, the change is still breaking, but the break points and remedy will be obvious: the methods are no longer static, so they need to change RelMetadataQuery.foo() to RelMetadataQuery.instance().foo().

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            julianhyde Julian Hyde
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment