Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-789

MetaImpl.MetaCatalog should expose TABLE_CAT instead of TABLE_CATALOG

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.3.0-incubating
        • Fix Version/s: 1.4.0-incubating
        • Component/s: avatica
        • Labels:
          None

          Description

          According to http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getCatalogs(), MetaImpl.MetaCatalog should expose TABLE_CAT instead of TABLE_CATALOG

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Good catch. The "TABLE_CATALOG" field came from MetaImpl.MetaCatalog.tableCatalog (derived by converting camel-case to upper-case with underscores) and renaming it to tableCat solves the problem.

            Can you please quickly review that the field names in MetaImpl match the names in the JDBC spec and log any other violations?

            Show
            julianhyde Julian Hyde added a comment - Good catch. The "TABLE_CATALOG" field came from MetaImpl.MetaCatalog.tableCatalog (derived by converting camel-case to upper-case with underscores) and renaming it to tableCat solves the problem. Can you please quickly review that the field names in MetaImpl match the names in the JDBC spec and log any other violations?
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Tentative fix here: https://github.com/julianhyde/incubator-calcite/commit/d44ff78d42b0e6e7b8372c38eb360c5de331e445

            Show
            julianhyde Julian Hyde added a comment - Tentative fix here: https://github.com/julianhyde/incubator-calcite/commit/d44ff78d42b0e6e7b8372c38eb360c5de331e445
            Hide
            Permalink
            liyang.gmt8@gmail.com liyang added a comment -

            Em.. on a second look, MetaColumn misses SCOPE_SCHEMA as well. Other major metas (catalog, schema, table, table type, column) are fine.

            Show
            liyang.gmt8@gmail.com liyang added a comment - Em.. on a second look, MetaColumn misses SCOPE_SCHEMA as well. Other major metas (catalog, schema, table, table type, column) are fine.
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/464fd364.

            Li Yang, thanks for checking that we output the right columns according to the JDBC spec. I have fixed the SCOPE_SCHEMA issue as well.

            Show
            julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/464fd364 . Li Yang, thanks for checking that we output the right columns according to the JDBC spec. I have fixed the SCOPE_SCHEMA issue as well.
            Hide
            Permalink
            jnadeau Jacques Nadeau added a comment -

            Resolved in release 1.4.0-incubating (2015-08-23)

            Show
            jnadeau Jacques Nadeau added a comment - Resolved in release 1.4.0-incubating (2015-08-23)

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                liyang.gmt8@gmail.com liyang
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development