Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-788

Allow EnumerableJoin to be sub-classed

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      1. Let EnumerableJoin constructor be protected, Kylin extends this class.
      2. Let SqlFunctions.divide(BigDecimal, BigDecimal) take a default MathContext to work around CALCITE-280 temporarily.

        Activity

        Hide
        jnadeau Jacques Nadeau added a comment -

        Resolved in release 1.4.0-incubating (2015-08-23)

        Show
        jnadeau Jacques Nadeau added a comment - Resolved in release 1.4.0-incubating (2015-08-23)
        Hide
        julianhyde Julian Hyde added a comment -

        Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/a76a2015.

        Thanks for the contribution, Li Yang!

        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/a76a2015 . Thanks for the contribution, Li Yang!
        Hide
        julianhyde Julian Hyde added a comment -

        I've split the patch and will commit the BigDecimal part as a fix for CALCITE-280.

        Show
        julianhyde Julian Hyde added a comment - I've split the patch and will commit the BigDecimal part as a fix for CALCITE-280 .
        Hide
        liyang.gmt8@gmail.com liyang added a comment -

        Patch attached. Please review and merge if OK. Thanks.

        Show
        liyang.gmt8@gmail.com liyang added a comment - Patch attached. Please review and merge if OK. Thanks.

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            liyang.gmt8@gmail.com liyang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development