Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-752

Add back sqlline as a dependency to csv example

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Tried to run some example query in calcite tutorial http://calcite.incubator.apache.org/docs/tutorial.html. Hit the following error, when started sqlline under example/csv:

      Error: Could not find or load main class sqlline.SqlLine.

      Turns out CALCITE-619 removed the SqlLine dependency, and CALCITE-692 added it back to calcite-core, but only in "test" scope. This means the dependency of sqlline is not transitive in example/csv project, and hence hit the error.

      Proposed change is to change the the scope from "test" to default, which is transitive.

        Issue Links

          Activity

          Hide
          jni Jinfeng Ni added a comment -

          Julian Hyde, would you please review the patch? Thanks!

          Show
          jni Jinfeng Ni added a comment - Julian Hyde , would you please review the patch? Thanks!
          Hide
          julianhyde Julian Hyde added a comment -

          Sorry I didn't see and review the patch earlier.

          The patch makes sqlline a dependency of core, and it will bring in its own dependencies (e.g. jline2). It's not acceptable to have "user interface" stuff like this in core.

          There's a better way to do this, which is to add sqlline as a test dependency in example/csv. I'll check in a fix based on that shortly.

          Show
          julianhyde Julian Hyde added a comment - Sorry I didn't see and review the patch earlier. The patch makes sqlline a dependency of core, and it will bring in its own dependencies (e.g. jline2). It's not acceptable to have "user interface" stuff like this in core. There's a better way to do this, which is to add sqlline as a test dependency in example/csv. I'll check in a fix based on that shortly.
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/fcb6ba5f .
          Hide
          jnadeau Jacques Nadeau added a comment -

          Resolved in release 1.4.0-incubating (2015-08-23)

          Show
          jnadeau Jacques Nadeau added a comment - Resolved in release 1.4.0-incubating (2015-08-23)

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              jni Jinfeng Ni
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development