Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-720

VolcanoPlanner.ambitious comment doc is inconsistent

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

       /**
         * If true, the planner keeps applying rules as long as they continue to
         * reduce the cost. If false, the planner terminates as soon as it has found
         * any implementation, no matter how expensive. The default is false due to
         * unresolved bugs with various rules.
         */
        protected boolean ambitious = true;
      

      The default is false due to unresolved bugs with various rules seems inconsistent with ambitious = true.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Agreed. Patch or pull request would be welcome.

        Show
        julianhyde Julian Hyde added a comment - Agreed. Patch or pull request would be welcome.
        Show
        smolav Santiago M. Mola added a comment - PR: https://github.com/apache/incubator-calcite/pull/86
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/eea91581 .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.3.0-incubating (2015-05-30).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.3.0-incubating (2015-05-30).

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            smolav Santiago M. Mola
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development