Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-677

RemoteDriverTest.testTypeHandling fails east of Greenwich

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Vladimir Sitnikov Reported:

      java.lang.AssertionError: expected:<1980-12-17> but was:<1980-12-16>
      at org.apache.calcite.avatica.RemoteDriverTest.testTypeHandling(RemoteDriverTest.java:366)
      
      Running 1.8u40, mac, GMT+3.

      It seems that one of Avatica's date-time methods (setTime, setTimestamp, setDate, getTime, getTimestamp, getDate) is ignoring the local timezone in one direction.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.3.0-incubating (2015-05-30).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.3.0-incubating (2015-05-30).
        Hide
        julianhyde Julian Hyde added a comment -

        Thanks for the review. I am working on setting up automated tests in various time zones but I would appreciate it if you run the suite from time to time in your TZ – I am looking after the western hemisphere, you can look after the east.

        Show
        julianhyde Julian Hyde added a comment - Thanks for the review. I am working on setting up automated tests in various time zones but I would appreciate it if you run the suite from time to time in your TZ – I am looking after the western hemisphere, you can look after the east.
        Hide
        vladimirsitnikov Vladimir Sitnikov added a comment -

        Works for me

        Show
        vladimirsitnikov Vladimir Sitnikov added a comment - Works for me
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/7f8ce197 .

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            julianhyde Julian Hyde
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development