Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-674

Add a SWAP_OUTER static instance to JoinCommuteRule

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0-incubating
    • Fix Version/s: 1.3.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      To create another static instance of JoinCommuteRule to enable swapping outer joins as JoinCommuteRule.INSTANCE does not.

      1. CALCITE-674.patch
        2 kB
        Maryann Xue
      2. CALCITE-674-v2.patch
        5 kB
        Maryann Xue

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Review comments:

        • Clarify the "Outer joins cannot be permuted." comment at the top of JoinCommuteRule
        • Change the "The singleton" comment, which is no longer true
        • Add an overloaded constructor and deprecate the current one (to be removed before 2.0)
        • Add a test to RelOptRulesTest.java
        Show
        julianhyde Julian Hyde added a comment - Review comments: Clarify the "Outer joins cannot be permuted." comment at the top of JoinCommuteRule Change the "The singleton" comment, which is no longer true Add an overloaded constructor and deprecate the current one (to be removed before 2.0) Add a test to RelOptRulesTest.java
        Hide
        maryannxue Maryann Xue added a comment -

        Thanks for your review, Julian Hyde! Updated the patch accordingly.

        Show
        maryannxue Maryann Xue added a comment - Thanks for your review, Julian Hyde ! Updated the patch accordingly.
        Hide
        julianhyde Julian Hyde added a comment -

        Looks good. I've committed to https://github.com/julianhyde/incubator-calcite/tree/new-master and will commit to apache master after the release.

        Show
        julianhyde Julian Hyde added a comment - Looks good. I've committed to https://github.com/julianhyde/incubator-calcite/tree/new-master and will commit to apache master after the release.
        Hide
        maryannxue Maryann Xue added a comment -

        Thank you, Julian Hyde!

        Show
        maryannxue Maryann Xue added a comment - Thank you, Julian Hyde !
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/ec925e2d .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.3.0-incubating (2015-05-30).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.3.0-incubating (2015-05-30).

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            maryannxue Maryann Xue
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development